tofodroid
commented
6 months ago Wow, these look amazing! My original models were all designed intentionally to be exactly the size of one block which made it easier for me to create them since my modeling skills are not very good... 😅
I'd definitely appreciate any other models and texturing that you're interested in contributing! It should definitely be possible for me to sync up the hitboxes with the new instrument sizes. 👍
One other thing that I will need to change to accommodate larger models would be customizing the "sitting" pose used for each instrument so that the player isn't continuing to sit on the floor while playing them. I haven't tried to do that before so it will take a bit more learning on my end to figure out the best way of doing that.
Re: Piano Bench - I like this idea! It'll be a bit tricky to implement because right now MIMI expects the player to "sit" on the instrument itself so that it knows what instrument the player is currently playing. I'm thinking I could potentially make it so that when a piano bench is present the player will appear to sit on it and when a bench is not present the player will appear to stand, but I'll have to play around with that a bit. I like the idea of the inventory space as well! I'm going to open up a new feature request for this and credit it to you so that I can track it separately.
Re: Piano Sheet Music - I definitely think that's something that could be done for decoration! As far as having it play a recorded track, that will require some more significant work but does fit thematically with this other feature suggestion: https://github.com/tofodroid/mimi-mod/issues/108 so it's something I will consider! I'm going to put a comment on that issue linking to this one.
Merancapeman
Is your improvement request related to a problem? Please describe. A lot of the block instruments (eg. piano, contrabass, harp, etc.) are way too small.
Describe the solution you'd like All of the block instruments should be remodelled so that they are the correct size when placed next to a player. To put my money where my mouth is, I sketched up models for the piano and the contrabass in blockbench. The models can be larger than a block while only taking up one block, but it would be nice if this change included scaled up hitboxes (eg. making the contrabass two blocks tall).
To scale them to the player, I looked up the dimensions of a typical instrument in cm and translated it assuming 1 block = 1 meter. Since instrument specifications are pretty easy to find, you can use them as a blueprint once you know the pixel scaling.
Additional context I've also done plenty of work texturing, so if I can contribute, I would love to model and texture a bunch more!
P.S. with this idea, while not completely necessary, a piano bench with 9 inventory slots would be wonderful. Bonus if you can add sheet music that you can put onto the piano's music stand for decoration or to make it play a recorded track! But now I'm just getting carried away.