search

tofodroid / mimi-mod

Musical Instrument Minecraft Interface
MIT License
13 stars 4 forks source link

[BUG] MIDI files suddenly not loading #144

Open Epik-B0mber opened 2 months ago

Epik-B0mber commented 2 months ago

Describe the bug Hello Tofo! It's Epik again, and it's been all smooth sailing for a while until the past couple months. I want to disclaim that I took a bit of a break for a couple months and swapped over from my first hybrid provider to Mohist, so this is apart of a mix of issues elsewhere, but I wanted to throw it out just in-case! The issue occurs on Forge 1.20.1 utilizing v 859 of Mohist. The midi files display after being refreshed, but attempting to play them keeps the Play button doing an infinite loading loop, which was not present less than two weeks ago (absolutely no clue right now lol)

To Reproduce Steps to reproduce the behavior:

  1. Be on server and try to use the Maestro
  2. Pain

Log log.txt

Environment (please complete the following information):

Thanks again!

tofodroid commented 2 months ago

Hey Epik! Nice to hear from you again!

Looking at that log there seems to be an incompatibility between some of the server code in Mohist and MIMI. It looks like for some reason Mohist does not allow certain code actions to happen that the vanilla server does allow (in particular it seems to not allow modifying the world outside of the main server thread).

I'll poke around a bit and see if I can get the problematic part of the code to run on the main server thread instead but it may be a bit of whack-a-mole to figure out because I'm not sure what other incompatibilities may exist similar to this one. MIMI relies pretty heavily on threading so if threading behavior is significantly different in Mohist than the vanilla server it may be challenging to get MIMI to place nicely with it.

I'll see what I can do though! Thanks for the report!

Epik-B0mber commented 1 month ago

Hey there! Thanks for dissecting the problem! Sorry for the delayed response, I keep thinking Github has some sort of notification system but I guess not XD Yeah since we've talked I happened to switch over to Mohist for more stability, though I must say this is a new issue as the switch did not reap an instant breaking to the mod. I think this may have something to do with version 864-845 as I only began noticing it in the past two-ish months when trying to ring the bells at that church I showed you (the town's grown, huzzah!)

I hope you can definitely get something done, as I'm sure others may run into this soon. Let's hope the Mohist team won't shut the door! Cheers.

Epik-B0mber commented 1 month ago

Hey boss! I've been doing some experimenting with other server providers, and I had a server of mine crash out from memory leakage, which generated this error. This is still from a MOHIST environment, so hope it helps in some way.

crash-2024-09-30_02.32.21-server.txt