Empty rows always last possible?

tofsjonas / sortable

Vanilla JavaScript table sort

The Unlicense

423 stars 49 forks source link

Closed nepsilon closed 1 year ago

nepsilon commented 1 year ago

Is it possible to make empty rows always last after sorting? Similar to what SQL does with ORDER BY foo NULLS LAST.

So that no matter ascending or descending sort is applied on a column, empty values will always be at the bottom.

tofsjonas commented 1 year ago

I don't see why not. Thanks for your suggestion! 😊️

nepsilon commented 1 year ago

That was fast! Thanks Jonas.

I tested it and here is some feedback:

I realized n-last doesn't work with data-sort. Demo here https://jsfiddle.net/a0pfodcr/
It also doesn't remove any white-space before checking if empty, but that can be handled when formating the actual HTML, the whole <td></td> must be on a single line.

tofsjonas commented 1 year ago

Looks like you discovered a much older bug. Cool. Thanks again! 🙏️

nepsilon commented 1 year ago

Thanks for your prompt reply to this!

I tested it again and confirm n-last now works with data-sort 👍