Closed Abhinavcode13 closed 3 months ago
CC : @kvendingoldo
Looks fine from my side, @dvaumoron please check it.
@Abhinavcode13 btw. you also need to fix CI DCO check.
Still DCO CI - failed.
yep. You can fix it by the following commands: $ git rebase HEAD~3 --signoff $ git push --force-with-lease origin main
I understand that the default nil values prevent a panic. However, I included explicit type assertions for map[string]any
to make the function's behavior more predictable.
Hi @Abhinavcode13,
Among my commit today, I changed to create a versions
variable in place of reassigning object, to make the code more understandable, however I still did not want to add unnecessary line for an earlier return.
If you are willing to contribute officially, take care of the DCO check, it would have allowed me to merge your proposal and modify the code afterward.
thanks for pointing out