AUR: ERROR: tenv-bin is not available for the 'x86_64' architecture.

tofuutils / tenv

OpenTofu / Terraform / Terragrunt and Atmos version manager

https://tofuutils.github.io/tenv/

Apache License 2.0

662 stars 32 forks source link

AUR: ERROR: tenv-bin is not available for the 'x86_64' architecture. #174

Closed muchgitsuchwow closed 3 months ago

muchgitsuchwow commented 3 months ago

Describe the bug https://github.com/tofuutils/tenv/pull/173 introduced a new PKGBUILD on AUR. This new PKGBUILD supports only:

arch=('aarch64' 'i686')

Expected behavior AUR tenv-bin package is available for all supported archs again, like x86_64.

Screenshots

Environment (please complete the following information):

Additional context

kvendingoldo commented 3 months ago

@muchgitsuchwow thank you for reporting. I'm working on this issue, hope that it will be fixed today

kvendingoldo commented 3 months ago

Trying to find what's wrong with goreleaser; Based on that I see that we have to had x86_64 package

https://github.com/goreleaser/goreleaser/blob/8ad6b3479bc9999f0567cd84c33a247b5d17d98e/internal/pipe/aur/aur.go#L267

kvendingoldo commented 3 months ago

Dunno why goreleaser decided to use i686 instead of pure 386. @clee231 @muchgitsuchwow guys, do you think that it's a problem for 386 users?

    case "386":
        return "i686"

clee231 commented 3 months ago

@kvendingoldo I think it is fine to use i686. It's a newer revision of the x86 platform and should be backwards compatible with i386. My understanding is that each newer revision supports additional instruction sets. They don't remove usually remove opcodes after introduction.

At least for ArchLinux, the latest release of the 32-bit variant only mentions support for i686, so that may be why goreleaser is making that switch.

I took some time to also take a look at the executables being generated in the latest v2.1.5 release and they are all built for the i386 platform, so even if someone tried to force install on an older platform, it should work still.

kvendingoldo commented 3 months ago

@clee231 @muchgitsuchwow looks like it works now, please check it

muchgitsuchwow commented 3 months ago

Hey there, PKGBUILD in AUR looks better. Will test installation and therefor binaries tomorrow/Tuesday (no access to the related machine right now). Thanks though for the quick response(s) and probably the fix!

clee231 commented 3 months ago

I was able to test it on my machine. I was able to install v2.1.6 with no issue now on x86_64 using the latest PKGBUILD. Thanks for addressing this so quickly, @kvendingoldo !

kvendingoldo commented 3 months ago

@clee231 I've added you to AUR as contributor/maintainer. Will wait for @muchgitsuchwow response and if everything ok, will close the ticket.

muchgitsuchwow commented 3 months ago

Thank you, everything looks good! :)