search

tog22 / eaforum

EA Forum
Other
12 stars 1 forks source link

Password reset not working #50

Closed tog22 closed 8 years ago

tog22 commented 8 years ago

On 21 January 2016 at 08:09, Frazer Kirkman frazer@frazerk.net wrote: Hi,

after requesting a password reset, receiving the email and clicking on the the link in that email, I am taken to a page that says:

The page you requested does not exist

on http://effective-altruism.com/resetpassword/abcasgfrg

tog22 commented 8 years ago

@arichard4 are you free to look at this, and reply to Frazer ccing Peter as appropriate?

arichard4 commented 8 years ago

Yeah, will do.

tog22 commented 8 years ago

:heart: Alex

patbl commented 8 years ago

The password-reset URL that you get in the e-mail works for only one form submission. You get the "does not exist" error if you use the link after you submit the form. It would be nice to have a more informative message ("That password-reset link has expired. Click here to request a new one.").

I'm not sure whether Frazer was trying to use an expired link or whether there's a bug. I'll ask him what happens if he tries again.

patbl commented 8 years ago

There does seem to be another bug to do with resetting passwords: After you submit the form, you are logged in, but the message that's displayed is "Your session has expired."

your-session-has-expired

tog22 commented 8 years ago

Thanks for contacting Frazer Patrick

On 7 February 2016 at 12:39, Patrick Brinich-Langlois < notifications@github.com> wrote:

There does seem to be another bug to do with resetting passwords: After you submit the form, you are logged in, but the message that's displayed is "Your session has expired."

[image: your-session-has-expired] https://cloud.githubusercontent.com/assets/1735266/12875108/cd05e456-cd97-11e5-856e-61b6ad7ad48f.png

— Reply to this email directly or view it on GitHub https://github.com/tog22/eaforum/issues/50#issuecomment-181111934.

peterhurford commented 8 years ago

@tog22 @patbl Did this ever get fixed?

patbl commented 8 years ago

No. I couldn't reproduce the bug. I'll contact Frazer again.

On 2 April 2016 at 16:22, Peter Hurford notifications@github.com wrote:

@tog22 https://github.com/tog22 @patbl https://github.com/patbl Did this ever get fixed?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/tog22/eaforum/issues/50#issuecomment-204823187

tog22 commented 8 years ago

Great, thanks! What did he say?

On 2 April 2016 at 18:53, Patrick Brinich-Langlois <notifications@github.com

wrote:

No. I couldn't reproduce the bug. I'll contact Frazer again.

On 2 April 2016 at 16:22, Peter Hurford notifications@github.com wrote:

@tog22 https://github.com/tog22 @patbl https://github.com/patbl Did this ever get fixed?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/tog22/eaforum/issues/50#issuecomment-204823187

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/tog22/eaforum/issues/50#issuecomment-204849134

patbl commented 8 years ago

He didn't respond. Maybe we should close this if no one else has reported it.

tog22 commented 8 years ago

Sure, just reopen if it he does reply.

On 9 April 2016 at 09:28, Patrick Brinich-Langlois <notifications@github.com

wrote:

He didn't respond. Maybe we should close this if no one else has reported it.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/tog22/eaforum/issues/50#issuecomment-207815684

patbl commented 8 years ago

Frazer got back to me. Here's a more-detailed account of his problem. I'll investigate soon (50% chance by tomorrow).

screenshot 2016-04-16 21 14 14

patbl commented 8 years ago

It would probably be worth fixing the "Your session has expired" message. I'll work on that.

Frazer tried changing his password, and apparently it didn't update. So there may be an additional, more-subtle bug. But I haven't been able to reproduce it, so I'll set that aside for now.

peterhurford commented 8 years ago

@patbl Any updates on being able to reproduce? Any other things to do here? Otherwise we can close.

patbl commented 8 years ago

I tried to fix one of the issues (showing "Your session has expired" after you successfully reset your password) here.

It's not a big deal, but I think I should verify that this fix and the ones in my other pull requests work on production before we close the issues—leaving them open makes me somewhat less likely to forget to do this.

I wasn't able to reproduce Frazer's other bug, which was that when he seemingly successfully submitted a new password, it wasn't updated (it didn't work if he logged out and logged in again).

peterhurford commented 8 years ago

@patbl Cool, if you can verify https://github.com/tricycle/eaforum/pull/36 I think we can close this.

tog22 commented 8 years ago

Good idea, let's make that the policy for closing issues from now on On 26 Apr 2016 5:08 pm, "Peter Hurford" notifications@github.com wrote:

@patbl https://github.com/patbl Cool, if you can verify tricycle#36 https://github.com/tricycle/eaforum/pull/36 I think we can close this.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/tog22/eaforum/issues/50#issuecomment-214925742

patbl commented 8 years ago

You no longer see "Your session has expired" after resetting a password.