Closed peterhurford closed 8 years ago
I tried fixing this in tricycle/eaforum#31, but it seems that the development.ini
setting isn't what controls this in production. There are other discrepancies between the list in development.ini
and the generated JavaScript in production, namely in the feeds for Overcoming Bias, Slate Star Codex, Jeff's blog, and Open Phil.
// development.ini:
feedbox_urls = http://www.overcomingbias.com/feed,
http://slatestarcodex.com/feed,
http://reflectivedisequilibrium.blogspot.com/feeds/posts/default,
http://feeds.feedburner.com/TheGivewellBlog?format=xml,
http://80000hours.org/blog/feed.atom,
http://rationality.org/blog/feed/,
http://feeds.feedburner.com/EverydayUtilitarian?format=xml,
http://www.jefftk.com/news.rss,
http://www.givinggladly.com/feeds/posts/default,
http://www.openphilanthropy.org/blog/rss
// production JavaScript:
var urls = ["http://slatestarcodex.com/tag/rationality/feed",
"http://reflectivedisequilibrium.blogspot.com/feeds/posts/default",
"http://feeds.feedburner.com/TheGivewellBlog?format=xml",
"http://80000hours.org/blog/feed.atom",
"http://rationality.org/blog/feed/",
"http://feeds.feedburner.com/EverydayUtilitarian?format=xml",
"http://www.givinggladly.com/feeds/posts/default",
"http://www.jefftk.com/news/giving.rss"];
I imagine this is something that we'd have to ask someone at Trike to update.
That's correct. @arichard4 knows what we need to ask Trike to update - what is that Alex?
@arichard4 @tog22 @patbl I can contact Trike. What should I say?
My guess is that they need to make the same change I made in
https://github.com/tricycle/eaforum/pull/31/files in another file (perhaps
named production.ini.erb
).
On 26 April 2016 at 16:16, Peter Hurford notifications@github.com wrote:
@arichard4 https://github.com/arichard4 @tog22 https://github.com/tog22 @patbl https://github.com/patbl I can contact Trike. What should I say?
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/tog22/eaforum/issues/56#issuecomment-214916113
@arichard4 knows. I'm just emailing him ccing you guys to check.
Has anything happened on this?
Not to my knowledge!
@tog22 @arichard4 What are the next steps on this?
The feedbox is generated from a list of rss urls in development.ini. development.ini is in the .gitignore; it is generated from development.ini.erb in the build process, but can't be directly updated via git. (It's in the .gitignore because it also contains stuff involving debugging, ports, etc.) To get the changes to live, Trike will need to manually update r2/development.ini. Specifically, they will need to append ", http://www.openphilanthropy.org/blog/rss" to the end of feedbox_urls, as was done for development.ini.erb in this commit:
Contacted Trike.
Trike just removed development.ini from the .gitignore, which works too. I'll push the open phil addition; we all now need to use the same development.ini (e.g. use the same port)
@arichard4 👍
I don't think this worked out...
Maybe we should cut our losses.
Sorry @peterhurford I haven't been tracking this issue. Production gets deployed with a production.ini
that is kept in a separate, private repo. This is the thing that needed to be updated with the additional URL. I've just updated and deployed it.
Wowowowow, it's fixed!
Thanks @moggyboy! 👍
Where? If you mean the RSS feed I think it already is, right @patbl / @arichard4 ?