search

tog22 / eaforum

EA Forum
Other
12 stars 1 forks source link

Stop HTML comments showing in post previews #67

Closed tog22 closed 8 years ago

tog22 commented 8 years ago

When there are HTML comments <!-- like this --> in the first few lines of a post, they show up in the preview on the front page at http://effective-altruism.com/ . They'd need filtering out for this.

tog22 commented 8 years ago

Would you be OK to do this @arichard4 ?

tog22 commented 8 years ago

(No worries if not obviously! What's your general availability for tech work these days.)

arichard4 commented 8 years ago

I start fulltime work Monday. So not so good.

tog22 commented 8 years ago

Gotcha! @patbl, would be great if you could try this when you have a chance!

patbl commented 8 years ago

Sure. I tried the following in dev and couldn't reproduce the issue:

<!--lol test -->
<p>rstrst</p>
<!-- like this -->
<p>huh what?</p>

If you have access to a post with this problem, could you send me a link, or the HTML itself (if it was your post)?

patbl commented 8 years ago

@tog22 Do you have an example?

tog22 commented 8 years ago

Sure, see 'Help SHIC Get Off The Ground' at http://effective-altruism.com/user/Tom_Ash/ . By the way, I'm stepping back from .impact work so won't be dealing with its EA Forum work from now on - I've asked Georgie Mallett (the new manager of .impact) and Peter to say who the best person to tag is (it may revert to @peterhurford for a while).

peterhurford commented 8 years ago

Here's an example:

patbl commented 8 years ago

Fixed by tricycle/eaforum#51.