togglepro / pundit-resources

Integrate Pundit policies with jsonapi-resources
MIT License
46 stars 39 forks source link

overriding `current_user` can conflict with common libraries such as Devise #16

Closed kevinmtrowbridge closed 8 years ago

kevinmtrowbridge commented 8 years ago

Hi!

Your gem is lovely, cutting-edge (in my opinion) due to the rising stars of JSONApi::Resources and Pundit, and is working super well for me.

I had two issues while integrating it:

Thanks for your gem! I love how it calls into Pundit's scopes ... I was surprised at how tiny and how well it fit bridges the gap between Pundit & JSONApi::Resources.

In particular, I have been fighting to use JSONApi::Resources -- I really prefer that approach and I see that the Rails team has also been encouraging them. My two big problems with it were: fine-grained integration with Pundit & Devise, and caching. Your gem solved the first. Caching, I see in their Github issues that they are working on this.

KT

barelyknown commented 8 years ago

@penman Can you up the version, publish to rubygems, and close this issue? Thanks.

alyssais commented 8 years ago

Done!