search

tohojo / flent

The FLExible Network Tester.
https://flent.org
Other
428 stars 79 forks source link

WARNING: Built wheel for flent is invalid: Metadata 1.2 mandates PEP 440 version, but '2.1.1-git-d48ccab' is not #279

Closed netravnen closed 1 year ago

netravnen commented 1 year ago

I get a build error when installing directly from master branch.

https://github.com/pypa/pip/issues/8368

Should I be concerned?

$ python3 -m pip install git+https://github.com/tohojo/flent.git
Defaulting to user installation because normal site-packages is not writeable
Collecting git+https://github.com/tohojo/flent.git
  Cloning https://github.com/tohojo/flent.git to /tmp/pip-req-build-sngad9hv
  Running command git clone --filter=blob:none --quiet https://github.com/tohojo/flent.git /tmp/pip-req-build-sngad9hv
  Resolved https://github.com/tohojo/flent.git to commit d48ccabd4ebe54af7a4ad1fb25321581a538a054
  Preparing metadata (setup.py) ... done
Building wheels for collected packages: flent
  Building wheel for flent (setup.py) ... done
  Created wheel for flent: filename=flent-2.1.1_git_d48ccab-py2.py3-none-any.whl size=297431 sha256=183488b08f294a3c158e52acb441994165a6afd69222554318f18523b00a4332
  Stored in directory: /tmp/pip-ephem-wheel-cache-6vutq3dl/wheels/53/87/fe/9dc9c29f72737cb7b61b7c26a9d1fff71398ae082bb43f9b65
  WARNING: Built wheel for flent is invalid: Metadata 1.2 mandates PEP 440 version, but '2.1.1-git-d48ccab' is not
Failed to build flent
Installing collected packages: flent
  Running setup.py install for flent ... done
  DEPRECATION: flent was installed using the legacy 'setup.py install' method, because a wheel could not be built for it. pip 23.1 will enforce this behaviour change. A possible replacement is to fix the wheel build issue reported above. Discussion can be found at https://github.com/pypa/pip/issues/8368
Successfully installed flent-2.1.1-git-d48ccab
tohojo commented 1 year ago

ch @.***> writes:

I get a build error when installing directly from master branch.

https://github.com/pypa/pip/issues/8368

Should I be concerned?

Hmm, not really. We attach a -git-$HASH version to builds from the git tree, and it seems pip doesn't like the format of that. Which, well, I didn't even know you could point pip at a git repository like that, so it hasn't really been a big concern. I guess we could change the format (seems to be enough to just switch the prefix to start with a '+' instead of a '-') to make pip happy...

netravnen commented 1 year ago

Fixed in fee05fa8885ced6861837ee36fd171bc38f9d24b