search

tohojo / xdp-paper

Source text and experimental data for our paper describing XDP
138 stars 29 forks source link

parse_ipv6 implementation is missing #1

Closed calavera closed 6 years ago

calavera commented 6 years ago

Hi! :wave:

I was reading the paper and I noticed that in Listing 1 there is a function implementation missing. In line 55 of that code, there is a call to ipproto = parse_ipv6(data, nh_off, data_end), but that function is never defined before that call.

tohojo commented 6 years ago

David Calavera notifications@github.com writes:

Hi! :wave:

I was reading the paper and I noticed that in Listing 1 there is a function implementation missing. In line 55 of that code, there is a call to ipproto = parse_ipv6(data, nh_off, data_end), but that function is never defined before that call.

Yeah, the version in the paper omits a few details in order to fit on the page. The full example is distributed with the kernel source code. See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/samples/bpf/xdp2_kern.c

calavera commented 6 years ago

that makes a lot of sense, thanks. Maybe, you should consider adding that reference to the paper, I'm not sure if it's there.

tohojo commented 6 years ago

Well, it sort of says so in the figure text? :)

On 27 October 2018 21:48:51 CEST, David Calavera notifications@github.com wrote:

that makes a lot of sense, thanks. Maybe, you should consider adding that reference to the paper, I'm not sure if it's there.