tohpinren / pe

0 stars 0 forks source link

Member fields that are not entered should not be shown #14

Open tohpinren opened 10 months ago

tohpinren commented 10 months ago

I have created multiple members without entering the optional fields. However, the optional fields are still shown in the members list as empty. These empty optional fields do not add value to me as a CCA head and might even cause confusion. They should not be shown if they were not entered.

Screenshot 2023-11-17 at 5.07.42 PM.png

nus-pe-bot commented 10 months ago

Team's Response

Hello there, thank you for raising this issue. The fields should be there for the user to have a clear overview of all the details attached to the member. Furthermore, this provides consistency for the height of the member cards as well as maintains the order of the member fields. If empty fields were not shown, the member cards will have varying heights and will not follow the order of name -> gender -> phone -> address -> email -> hours -> remark. Plus, this serves to remind the CCA leader of members with missing information, allowing them to fill in the blanks.

Also, since this is purely a cosmetic issue that does not hinder the functionality of the app, we will be adjusting the severity to very low.

As such, we will be rejecting this issue. Thank you.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As to the height of the member card mentioned, it would still be possible to have the same consistent height for each member card if the blank fields are not present. Maybe it would be better if the blank fields are replaced by something like "[NOT FILLED]". This would reduce confusion for the user. This would give more information to the user than entering blank fields which would cause confusion and does not add value.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]