search

tohuwabohu / puppet-duplicity

Puppet module to manage backups based on duplicity.
Apache License 2.0
8 stars 33 forks source link

Allow no user and pass to be defined. #15

Closed tmclaugh closed 7 years ago

tmclaugh commented 9 years ago

Unbreaks s3 backend when using EC2 instance roles.

tmclaugh commented 9 years ago

I don't like changing defaults but I wasn't sure of a better way to handle not defining a username or passowrd. Wasn't sure if there were use cases for '' as a user or pass.

tohuwabohu commented 9 years ago

Nice one! I'd go one step further and argue that only a non-empty string should mean that TARGET_USER and TARGET_PASS are set. So even for the empty string case the environment variables should be omitted. Any chance you could add the empty-string check as well?

Also, can I kindly ask you to update the documentation of the parameter?

tohuwabohu commented 7 years ago

Timeout + there were recently made changes to unbreak EC2 instance profiles in #50 .