Logrotate error in duply setup

[bitfield]

Attempting to apply the manifest gives this error:

Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Logrotate::Rule[duply]: rotate must be an integer at /etc/puppet/modules/logrotate/manifests/rule.pp:306:7  at /etc/puppet/modules/duplicity/manifests/setup.pp:59

The relevant part of duplicity::setup is:

  logrotate::rule { 'duply':
    ensure       => present,
    path         => "${duplicity::duply_log_dir}/*.log",
    rotate       => '5',

It doesn't seem to like the quoted '5', but removing the quotes doesn't fix the issue. This may be a problem with the logrotate module, but I'm not sure.

[tohuwabohu]

Which version of logrotate are you using? Last I've looked logrotate didn't support proper numbers for rotate.

[jarkomes]

I looks like an error in logrotate 1.1.1. The github version has this issue solved. https://github.com/rodjek/puppet-logrotate/

[tohuwabohu]

The github version has this issue solved. https://github.com/rodjek/puppet-logrotate/

Last time I've checked there wasn't a commit since years. You're not referring to a fork, do you?

[dpash]

It would be handy to switch to yo61/logrotate, which is an improved fork of rodjek, which appears to have died.

[tohuwabohu]

Change contained in 4.0.0.