search

tohuwabohu / puppet-duplicity

Puppet module to manage backups based on duplicity.
Apache License 2.0
8 stars 33 forks source link

WIP: Distinguish different distributions for paramiko dependency #60

Open punycode opened 4 years ago

punycode commented 4 years ago

Different distributions all use different package names for the python-paramiko dependency. Sometimes there are multiple such packages, one for Python 2.x and one for Python 3.x. Since this is ultimately used by duplicity itself, the correct version to install is the one for the Python version used by the duplicity installation.

We therefore depend on the Python version that comes with the distribution duplicity package.

PS: I'm not very good at Puppet RSpec tests and I did not find any regarding the python-paramiko dependency, that I could adapt. Perhaps someone would like to pick up my proposal and add these tests.

PPS: The Fedora branches for the python-paramiko dependency are a guess from what ever information I could pull from public package repository information. All our Puppet-managed Fedora boxes are currently in Corona home office isolation and not easily reachable. The RHEL ones are also a bit problematic, since they actually depend on EPEL. Should we depend on the epel-release package here?

tohuwabohu commented 4 years ago

Looks good to me! Let me know when this is ready for merge.