search

tohuwabohu / puppet-duplicity

Puppet module to manage backups based on duplicity.
Apache License 2.0
8 stars 33 forks source link

Fix pre 1.7.1 error (purgeFull vs. purge-full) #9

Closed vorlon closed 8 years ago

vorlon commented 9 years ago

This adds a duply_version variable which is filled with defaults for Ubuntu and Debian. It is then used to decide on the command in the cron job. This is hopefully not too simple. Has been tested on Debian wheezy and jessie. Should resolve #4

tohuwabohu commented 9 years ago

@vorlon ?

tohuwabohu commented 9 years ago

@vorlon ?

vorlon commented 9 years ago

@tohuwabohu sorry for the silence You are right, some changes are needed here, I will get back to you about it

vorlon commented 9 years ago

What about something like

if ($duply_package_provider == 'archive') and ($duply_archive_version != $duplicity::params::duply_version) {
  $duply_version = $duply_archive_version
  }
  else {
    $duply_version = $duplicity::params::duply_version
  }

in init.pp and using $duplicity::duply_version in profile.pp?

tohuwabohu commented 9 years ago

Looks good to me.

luxflux commented 9 years ago

Any news here? I don't want to install it from source :(

vorlon commented 9 years ago

Just added the duply_version parameter as @tohuwabohu suggested, I also included some tests for the cron job when using different duply versions. To make testing possible in an easy way I also added a duply_version and duply_executable parameter to profile.pp.

tohuwabohu commented 9 years ago

@vorlon, can you please have a look at the merge conflict? thanks

vorlon commented 8 years ago

@tohuwabohu conflicts have been resolved and this works for me on Debian jessie. Please double check.

tohuwabohu commented 8 years ago

I've released version 3.6.0 to the forge. Thanks for the contribution.