toin0u / Geotools-laravel

Geo-related tools PHP library for Laravel 4 & 5
MIT License
240 stars 37 forks source link

Laravel 5 #7

Closed fevinta closed 9 years ago

fevinta commented 9 years ago

Do you plan to make this package compatible with Laravel 5?

toin0u commented 9 years ago

Sure! But you're welcome to make a PR :)

goranata commented 9 years ago

Hello, just to ask, when can we expect the package for L5 approx. ?

toin0u commented 9 years ago

Well, no so much time atm :-/ But it should be done as I can see a lot of people is asking for it :)

toin0u commented 9 years ago

@fernandovinta @goranata I've made the laravel5.x branch here https://github.com/toin0u/Geotools-laravel/tree/laravel5.x

Can you test it by requiring "toin0u/geotools-laravel": "dev-laravel5.x@dev" in your Laravel 5 project please ? If it's working as expected then I'll merge into master and release a new version. I'm waiting for your feedbacks :)

goranata commented 9 years ago

geotools-composer

Wow this was super quick. Looks like it works :)

Tested only with the Distance example code, the results are the same as the commented.

toin0u commented 9 years ago

Thank you @goranata :)

goranata commented 9 years ago

Any time, thank you @toin0u as well :)

toin0u commented 9 years ago

@goranata let's wait @fernandovinta's feedback as well before merging it to master :)

goranata commented 9 years ago

Yes off course, there is no need to rush :)

fevinta commented 9 years ago

Thank you @toin0u, worked perfectly in my project. I guess it is ready to master branch.

captura de tela 2015-02-23 as 09 29 12

toin0u commented 9 years ago

@fernandovinta Thank you for your report! I'll merge this asap :)

toin0u commented 9 years ago

@fernandovinta @goranata what do you think if I tag 1.0.0 ?

fevinta commented 9 years ago

@toin0u I think it is a good idea :)

toin0u commented 9 years ago

@fernandovinta @goranata so it's tagged 1.0.0 and thank you both of you! https://github.com/toin0u/Geotools-laravel/releases/tag/1.0.0

goranata commented 9 years ago

Excellent :)

RomainSauvaire commented 9 years ago

Well done Antoine (bien joué) !

toin0u commented 9 years ago

@goranata @RomainSauvaire Thanks :)

RomainSauvaire commented 9 years ago

You really need need Illuminate/Support ~4.0 to install Geotools ? What about the ~5.0 tag ? I feel lame using a previous version and because I need ~5 to use laravel/socialite... capture d ecran 2015-02-23 a 15 05 54

toin0u commented 9 years ago

No it's not needed :)