search

toinsson / pyrealsense

Cross-platform ctypes/Cython wrapper to the librealsense library (v1.x)
http://pyrealsense.readthedocs.io
Apache License 2.0
121 stars 46 forks source link

Update __init__.py, stream.py #16

Closed G-Paris closed 7 years ago

G-Paris commented 7 years ago

Thank you for all the work put into this library!

Made a small change to make the depth aligned to color stream work. Trying to make Infrared work as well, but haven´t got rs_stream.RS_STREAM_INFRARED working yet :(

toinsson commented 7 years ago

quick question though, why would you choose dev branch instead of master ?

G-Paris commented 7 years ago

This was my first commit on github, I'm a complete newbie and not familiar with standard practice. Made sense to me to propose a change to the development branch instead of the master. I thought you'd decide if and when you want it in the master branch.

Btw besides my Razer Stargazer(sr300 module), today I got my R200 from intel and tested it with the pyrealsense. The cv2 and vtk examples work out of the box. Ubuntu 16.04.

toinsson commented 7 years ago

no worries, I'll might have to be more clear in the future about PR.

I don't think I could change the destination branch myself, but you could: http://stackoverflow.com/questions/24159036/how-to-modify-a-pull-request-on-github-to-change-target-branch-to-merge-into