search

toinsson / pyrealsense

Cross-platform ctypes/Cython wrapper to the librealsense library (v1.x)
http://pyrealsense.readthedocs.io
Apache License 2.0
121 stars 46 forks source link

Replace global context with single context per service instance #46

Closed papr closed 7 years ago

papr commented 7 years ago

Replaces #45 which pushed to master instead of dev.

Edit: Just noticed that I could have simply changed the target of the old PR instead of making a new one. =/

toinsson commented 7 years ago

yes, sorry for not mentioning this. But it looks like you pushed some more code in the end.

It looks very good. I'll just do some testing locally before merging.

papr commented 7 years ago

Yeah, I am currently extending it with what we need for our integration. Feel free to criticize the features we are adding.

toinsson commented 7 years ago

I was thinking about changing Stream_Mode to StreamMode, to be more consistent with the naming so far, e.g. stream names and RealsenseError. What do you think ?

papr commented 7 years ago

I agree. I will make a pull request for that.

toinsson commented 7 years ago

I am currently updating the dev version with documentation change. Can change that also, don't bother.