Class view is showing synthetic getters, setters and constructors

toitware / web-toitdocs

MIT License

0 stars 0 forks source link

Class view is showing synthetic getters, setters and constructors #113

Open floitsch opened 3 years ago

floitsch commented 3 years ago

For example https://libs.toit.io/lib/directory.toit/DirectoryStream

The page shows the synthetic fd_ -> any and fd_= <new value>/any -> any.

multiple levels where we could solve this:

not include them in the json file
hide synthetic functions in the viewer.

I'm leaning towards not including them in the json file.

krzysiek641886 commented 3 years ago

Hi @floitsch ! I created the Pull Request #119 that will hide the all the elements that have a 'true value' of is_private parameter. Will this resolve this issue?

floitsch commented 3 years ago

I think this is a different issue. The synthetic getters and setters are (probably) also there for public fields. For those one needs to hide the functions that are synthetic. (It's an entry in the json).

krzysiek641886 commented 3 years ago

I see. It will be easy to extend the changes from PR that removes private elements

floitsch commented 3 years ago

Same is true for constructors.