toivoh / Debug.jl

Prototype interactive debugger for Julia
Other
86 stars 13 forks source link

Julia 0.2RC generates large numbers of warnings #51

Closed john9631 closed 10 years ago

john9631 commented 10 years ago

This is a great package. With the new Julia versions, the use of contains and add in Debug generated large numbers of warning messages. I've forked the repository and fixed the errors.

Substitute push! for add Substitute in for contains and reverse the parameter order.

My copy is here

I use IPython and thus IJulia a lot so I'm going to try to figure out why it goes into an infinite loop on hitting the breakpoint currently.

toivoh commented 10 years ago

Just fixed this yesterday :) Should be pushed now.

john9631 commented 10 years ago

Excellent. I can confirm that cloning Debug.jl and renaming the folder Debug provides a warning free version.

At this point, Pkg.add("Debug") resulted in this message:

unknown package Debug at In[8]:1 in add at pkg/entry.jl:45 in add at pkg/entry.jl:48 in anonymous at pkg/dir.jl:25 in cd at file.jl:22 in cd at pkg/dir.jl:25 in add at pkg.jl:19

toivoh commented 10 years ago

I don't understand why Pkg.add("Debug") would fail for you. Did this happen before, or was this the first time? Did you do a Pkg.update()?

john9631 commented 10 years ago

It may be the process by which I removed Debug before doing it. I had previously deleted your Debug folder from .julia before cloning my fork of Debug.jl. Then I renamed my folder to try your new one. So now I had no Debug folder in .julia.

At that point I entered Pkg.add("Debug") and got the message back. I tried it again.

And then I decide to clone your Debug.jl instead.

I'm very much a git newbie so I'm feeling my way towards understanding it.


Now that I have the cloned and renamed version in place if I got Pkg.add("Debug") I get "Nothing to be done"

I'll remove it . Actually I don't know how to do that other thank by deleting the folder. So I removed the folder.

And this time:

julia> Pkg.add("Debug")
INFO: Installing Debug v0.0.0
INFO: REQUIRE updated.

so I'm at a loss to explain why it wouldn't work. Unless it was being refreshed somewhere and so it wasn't available (not knowing how the Pkg system works).

toivoh commented 10 years ago

Ah ok, that likely explains it. I did update METADATA as well, so Pkg.update() should have pulled in the changes.

Otherwise, by http://docs.julialang.org/en/latest/manual/packages/#checkout-pin-and-free, it seems that Pkg.checkout("Debug") would have brought in the latest version of my master branch, and Pkg.free("Debug") would have brought everything back to normal. But I try publish to METADATA so that package users won't have to go through with such things. (As do most package maintainers, I believe.)