search

toivoh / Debug.jl

Prototype interactive debugger for Julia
Other
86 stars 13 forks source link

Fix deprecations (#59) #60

Closed tomasaschan closed 10 years ago

tomasaschan commented 10 years ago

In the massive deletion of deprecated functions when rc1 was released (#59), Base.has, Base.ref and Base.assign were removed.

I've simply find/replaced them with their replacements (haskey, getindex and setindex!), so I might very well have introduced new problems here, but all tests pass and my own debugging was able to progress smoothly (where it previously broke as soon as I tried to print something).

toivoh commented 10 years ago

Thanks for moving on this! I made a few comments above about things that need fixing. @BobPortmann: You are right, ideally in should be used instead of haskey for Envs. But for Scopes it shouldn't. Anyway, that can be fixed later. Once the other stuff is fixed I would like to get this merged so that the package is unbroken.

tomasaschan commented 10 years ago

@toivoh I'm not sure I'll be able to tell which usages of haskey are on Envs and which ones are on Scopes, so I'm probably not the right person to make the switch to in if it shouldn't be everywhere.

Is there anything else you want me to fix with this PR before it's merge-ready?

toivoh commented 10 years ago

@tlycken: That's fine, I can deal with in and haskey later. I was sure that I added a line note about :ref yesterday, but it must have got lost. Anyway, if you take away the change from :ref to :getindex and the changes in attic/, I'm ready to merge this.

tomasaschan commented 10 years ago

There. I guess there's room for squashing this a little if you care about it.

toivoh commented 10 years ago

That's ok, I can take it like this. Thanks!

tomasaschan commented 10 years ago

Great, thanks! =)