tojocky / inxi

Automatically exported from code.google.com/p/inxi
0 stars 0 forks source link

Better quassel handling for Qt 5 builds #69

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Current output of latest inxi with latest Quassel on sid:
<agaida> CPU~Quad core AMD Phenom II X4 965 (-MCP-) speed/max~800/3600 MHz 
Kernel~3.19.1-1-ck-amd64 x86_64 Up~16:15 Mem~2259.4/32179.1MB 
HDD~2572.6GB(45.0% used) Procs~208 Client~Quassel (pre v0.4.1) inxi~2.2.19  

Manjaro:
<HeinzDo> CPU~Quad core Intel Core i5-4670 (-MCP-) speed/max~3709/3800 MHz 
Kernel~4.0.0-1-MANJARO x86_64 Up~1:17 Mem~1324.0/7646.5MB HDD~1120.2GB(7.8% 
used) Procs~171 Client~Quassel [M] (pre v0.4.1) inxi~2.2.19

The reason is the different commandline parsing with Qt5:
Qt4: quasselclient -v
Quassel IRC: v0.10.0 (dist-575f27e)

Qt5: quasselclient -v
quassel v0.13-pre (0.12.0+5 git-8e2f578)

in Qt4 the output came from src/common/quassel.cpp line 129:
        std::cout << qPrintable("Quassel IRC: " + Quassel::buildInfo().plainVersionString) << std::endl;

in Qt5 the internal CommandLineParser is used - no chance to modify the output 
like before.

patch attached

Original issue reported on code.google.com by info.gcom.eu on 26 Apr 2015 at 12:40

Attachments:

GoogleCodeExporter commented 8 years ago
ok, thanks. 

Original comment by da...@techpatterns.com on 29 Apr 2015 at 10:00

GoogleCodeExporter commented 8 years ago
2.2.20 _should_ in theory have fixed this. If the pattern for the -v string is 
consistent it should work fine. Let me know.

I used a simpler method, simple gawk search parsing of the -v output, if it's:
Quassel IRC: line starter, it's the qt 4 way
if it's:
quassel [v]?[number] starter, it's qt 5, well really it's anything that starts 
with that forever.

I was debating also doing qt 5 checks, but that's too much to just get the irc 
client info, and is complicated an unreliable.

Original comment by inxi-...@techpatterns.com on 11 May 2015 at 10:13