Open zam6ak opened 7 years ago
+1
+1
+1
hello, I had the same issue, I got work in node v6.9.2 in this branch: --> https://github.com/gaboelnuevo/node-pdfium/tree/patch-node-version
I don't make a pull request because it need to be tested in older node versions to maintain backward compatibility.
Hi @gaboelnuevo , Thank you your patch. did you check the latest pdfium code if this it is corrected?
We may consider to create another branch for upper versions.
I only tested EMF page conversion in Win7 (x64)
I think that we can use NODE_MODULE_VERSION of node_version.h instead to maintain a same branch example:
/* Code for upper versions */
/ Code for older versions /
Note: 46 is only a example, 46 is node v4.0.0 version, I don't know exactly what versions are compatible with this fix.
any chance on this getting fixed? thanks..
Could you please try now?
node-pdfium fails with Node JS 6.5.0
error seems to be indicative of change in Node JS native API
..\..\..\third_party\pdfium\fpdfsdk\src\javascript\JS_Runtime.cpp(103): error C2660: 'v8::Isolate::New': function does not take 0 arguments [X:\node-pdfium\build\third_party\pdfium\javascript.vcxproj]
config step
build step