search

tojocky / node-printer

Native node.js printer
1.53k stars 441 forks source link

Up to date build #240

Open bkniffler opened 5 years ago

bkniffler commented 5 years ago

Hey, could we have a new, up to date, build? I guess many of the installation issues come from this library build artifacts being limited to ancient node versions.

tojocky commented 5 years ago

Hi, sure will do another build!

bkniffler commented 5 years ago

Great, thanks! I've tried so much stuff like forking and switching to prebuild instead of pre-gyp, but I can't manage to get it to work, even if builds are passing.

The most important versions are here: https://github.com/node-serialport/node-serialport/blob/0390af41b9a2c2ce0fba8be51515cecccde8414e/.travis.yml#L21

ps. Here is what I could do with prebuild: https://github.com/bkniffler/zebra-printer/releases Would love to make this a PR. While it seems to work nice on my mac, it gives me issues when I build a electron windows application on my mac, while node-serialport and node-sqlite3 don't. Maybe there is something wrong with the build script, since I was getting these issues before too? I don't know.

I published the package as zebra-printer, but if you're interested in a merge that's fine for me! Or if a new publish from your side fixes the problems I have got and you're not interested in prebuild, I'd remove it.

bkniffler commented 5 years ago

Any news? Cheers!