fix compile error for Electron v7 and v8 (NodeJS v12.8 or v12.13)

tojocky / node-printer

Native node.js printer

1.51k stars 436 forks source link

Closed goooseman closed 3 years ago

goooseman commented 4 years ago

Resolves #289, but I'm unsure how this change can affect users of the lib on different environments and NodeJS versions.

Tested on Mac OS 10.13 and Lubuntu 18.04 in an Electron v8.2.5 application with DNP Printer (using CUPS)

dhenson02 commented 4 years ago

+1 @tojocky see anything concerning?

tojocky commented 3 years ago

Thanks