Try to receive interface in the receiver

tokahuke / yaque

Yaque is yet another disk-backed persistent queue for Rust.

Other

79 stars 11 forks source link

Try to receive interface in the receiver #10

Closed tokahuke closed 3 years ago

tokahuke commented 3 years ago

Backlog:

[x] find a way to make things work without having to refactor everything.
[x] implement try_recv, try_rect_batch and try_recv_until.
[x] documentation for the new functions.
[x] tests for the new functions.

vedantroy commented 3 years ago

~~I think TryRecvError needs to satisfy Debug, otherwise unwrap won't work.~~ nevermind, I see that the error is more complicated, so that's probably why it doesn't satisfy debug.

Does the error module now need to be public so the caller can match against variants of TryRecvError?

Also I believe it is spelled queue.

tokahuke commented 3 years ago

(a) No, indeed, it needs to satisfy Debug. I will add that after work today. (b) Yes and no. Yes, the error types have to be public, but no, there is another way. I have reexported the errors to the crate's root, which has the same effect. (c) As you may have seen, I have found a bug in my implementation regarding long batches. The latest commit addresses that, but still needs tests to verify that it is now working correctly. Sorry that has sidetracked this PR a bit. (d) Where did see the "queue" typo?