search

tokahuke / yaque

Yaque is yet another disk-backed persistent queue for Rust.
Other
81 stars 11 forks source link

feat: allow for disabling crossbeam-channel #33

Open raphaelcoeffic opened 7 months ago

raphaelcoeffic commented 7 months ago

As it turns out, tokio does not mix well with notify when crossbeam-channels are enabled (see here).

In my tests with yaque added this way to my deps, it seems to work as expected (with this PR in place):

yaque = { version = "0.6.6", default-features = false, features = ["no-crossbeam-channel"] }

Fixes #32

tokahuke commented 7 months ago

I can't believe it's that simple! Do you have any resources on this funky behavior?

EDIT: Sorry! I saw the link in your comment.

alexander-camuto commented 7 months ago

wow

tokahuke commented 7 months ago

So, I will merge and create a new minor version tomorrow, when I have some time to look into this closely.

raphaelcoeffic commented 7 months ago

So, I will merge and create a new minor version tomorrow, when I have some time to look into this closely.

Thx a lot for your time!