search

tokamak-network / Tms-contract

GNU General Public License v3.0
0 stars 1 forks source link

Why do you use IERC20Upgradeable interface? #6

Closed usgeeus closed 3 weeks ago

usgeeus commented 1 month ago

Describe the bug Is there a specific purpose for using the IERC20Upgradeable interface?

Configuration

usgeeus commented 1 month ago

Also you imported ERC20.sol, but ERC20.sol is not used.

bayram98 commented 1 month ago

@usgeeus

The reason why I wanted to use IERC20Upgradeable is because I wanted to use the upgradable contracts. I think that upgradable contract logic would better to maintain the contracts production.

bayram98 commented 1 month ago

Also you imported ERC20.sol, but ERC20.sol is not used.

I think ERC.sol is not necessary. So I will be removing then on my new Pr.

https://github.com/tokamak-network/Tms-contract/pull/15

usgeeus commented 1 month ago

@usgeeus

The reason why I wanted to use IERC20Upgradeable is because I wanted to use the upgradable contracts. I think that upgradable contract logic would better to maintain the contracts production.

What does it have to do with the contract being upgradable and declaring the type of the token as IERC20Upgradeable?

Shivansh070707 commented 3 weeks ago

Hey , I think both IERC20upgradable and IERC20 interfaces are similar so we can use any of them