[Gas Efficiencies] optimize gas costs by modifying function visibility

[usgeeus]

Describe the bug functions are declared public unnecessarily.

Configuration

• Severity: Low

Impact wasting gas fee unnecessarily.

Recommendation L1CrossTrade.sol

• _approve() internal -> private
• _getChainID() public -> private
• makeEncodeWithSignature() public -> private
• getHash() public -> private

L2CrossTrade.sol

• _request() internal -> private
• _approve() internal -> private
• _getChainID() internal -> private
• getEnterHash() public -> private
• getHash() public -> private

*internal -> private Changing internal to private doesn't optimize gas costs, but it does make it more strict.

Exploit Scenario Demo

[zzooppii]

L1CrossTrade.sol i think front use fucntions

so L1CrossTrade.sol _approve() internal -> private --> _approve() private _getChainID() public -> private --> getChainID() public (not change) makeEncodeWithSignature() public -> private --> Need to consult with the front desk getHash() public -> private --> getHash() public (not change)

L2CrossTrade.sol _request() internal -> private --> _request() private _approve() internal -> private --> _approve() private _getChainID() internal -> private --> getChainID() public getEnterHash() public -> private --> getEnterHash() public (not change) getHash() public -> private --> getHash() public (not change)

I think it will change like this. I will tell you the final conclusion after discussing with the front desk.

[usgeeus]

I think unnecessary rpc calls can be made.

1. getChainID() In order to call a function in any contract on the frontend, you need the chainId in addition to the RPC settings in advance, is there any reason to call the getChainID function from frontend?

2. makeEncodeWithSignature(), gethash(), getEnterHash() abi.encodeWithSignature, abi.encode and keccak256 can be performed using ethers.js or other library in frontend. Is there any reason to call this function from frontend??

[zzooppii]

I plan to develop it in an easy-to-use way on the front end. If the front desk says it is not needed, I will change it entirely to private.

[usgeeus]

Ok thanks

[zzooppii]

@usgeeus I talked to the front team and adjusted the functions. Please confirm.

L1CrossTrade.sol _getChainID() public -> private makeEncodeWithSignature() public -> private getHash() public -> private

L2CrossTrade.sol _request() internal -> private _getChainID() internal -> private getHash() public