tokamak-network / crossTrade

Cross Trade is a new core service for optimistic rollups that complements standard withdrawals and fast withdrawals. It is trustless and do not require extensive backend.
4 stars 1 forks source link

Use indexed paramter for events for off-chain searching #48

Closed parth-15 closed 3 months ago

parth-15 commented 3 months ago

Describe the bug Indexed parameters are useful for quick offchain indexing of logs. Consider indexing applicable event parameters to support the searching and filtering abilities of offchain services.

In the current implementation, it is suggested to use indexed parameter for saleCount in events since saleCount is unique and this will be helpful for indexers and off-chain components(frontend).