search

tokamak-network / crossTrade

Cross Trade is a new core service for optimistic rollups that complements standard withdrawals and fast withdrawals. It is trustless and do not require extensive backend.
4 stars 1 forks source link

Insufficient warning for provideCT, editCT, claimCT #56

Open suahnkim opened 2 months ago

suahnkim commented 2 months ago

https://github.com/tokamak-network/crossTrade/blob/a92ad15c77a551e110ca716b89f510d91c53b549/contracts/L1/L1CrossTrade.sol#L56

Please add enough warning for provideCT, editCT, claimCT, as they can be executed from the contract without request transaction from L2.

See an example interface explanation provided Optimsm's code

zzooppii commented 2 months ago

@suahnkim Added WARING to L1's provideCT, cancel, and editFee respectively. Please check if the wording is appropriate.