J_7. add amount check [medium]

tokamak-network / crossTrade

Cross Trade is a new core service for optimistic rollups that complements standard withdrawals and fast withdrawals. It is trustless and do not require extensive backend.

4 stars 1 forks source link

J_7. add amount check [medium] #9

Closed usgeeus closed 5 months ago

usgeeus commented 6 months ago

Configuration

Severity : medium
Confidence : medium

Lines of Codes

https://github.com/tokamak-network/L2-FastWithdraw/blob/aefc050fdaf7c81e1cef3f4a1a5eeea70351b762/contracts/L2/L2FastWithdraw.sol#L63-L72

Description

Should check wether _totalAmount is greator than _fwAmount

Recommendation

require(_totalAmount ≥ _fwAmount)

zzooppii commented 5 months ago

https://github.com/tokamak-network/crossTrade/commit/40d85a0927aaf40bbe6ec2c34fae8c37dedb0319

usgeeus commented 5 months ago

Solved, closing this issue.