search

tokamak-network / gem-nft-contract

Project Opal contract repository
MIT License
1 stars 1 forks source link

[Code review: Contract Bugs]: (Question) What are the L2 specs? #44

Open Zena-park opened 5 hours ago

Zena-park commented 5 hours ago

Describe the bug

I thought L2 was tokamak-thanos. I think I was mistaken. Treasury's ton is ERC20, not the native token. This contract doesn't support Thanos. Am I understanding this correctly?

https://github.com/tokamak-network/gem-nft-contract/blob/b31e833a38901bee6287b869d34c523bfe13dea2/src/L2/Treasury.sol#L110-L113

Impact

No response

Exploit Scenario

No response

Recommendation

No response

Zena-park commented 3 hours ago

@mehdi-defiesta The tests in the documentation confirm that it is titan.

If it's not a supported contract in Thanos, I think I can close this issue.

I'll close it after your confirmation.

mehdi-defiesta commented 2 hours ago

@Zena-park Yes, This contract was intended to be deployed on Titan only. However this is still under discussion. Can you send me a link showing how ton transfers are made on Thanos ?