search

tokamak-network / tokamak-thanos

MIT License
7 stars 3 forks source link

Or 1807 fix issues from the internal audit s feedback #255

Closed nguyenzung closed 1 week ago

nguyenzung commented 1 week ago

Apply updated code to the codeReview branch

Thank you!

nguyenzung commented 1 week ago

Hi @theo-learner The base branch is read-only. Could you update the permission?

theo-learner commented 1 week ago

Hi @theo-learner The base branch is read-only. Could you update the permission?

Ok. Let me check and update it.

theo-learner commented 1 week ago

@nguyenzung Is it OK to change target branch from codeReview to main? We have to keep the branch permission of codeReview as project FBI's policy. Or I think we can merge it to OR-1810 branch, and then OR-1810 merge to main branch.

nguyenzung commented 1 week ago

@nguyenzung Is it OK to change target branch from codeReview to main? We have to keep the branch permission of codeReview as project FBI's policy.

I think it is okay @theo-learner

I will make other PR to merge the updated code to the main branch.

I make this PR so that we can review the result after internal audit easier arcoding @0x6e616d and @rlgns98kr opinions.

I will close this PR after every member verifies the result.

Let me think about how to merge to OR-1810. Thank you very much, Theo!

rlgns98kr commented 1 week ago

훌륭해요! 정말 고맙습니다, Brave!

메인에 합칠 수 있을 것 같아요!

@nguyenzung Is it OK to change target branch from codeReview to main? We have to keep the branch permission of codeReview as project FBI's policy.

I think it is okay @theo-learner

I will make other PR to merge the updated code to the main branch.

I make this PR so that we can review the result after internal audit easier arcoding @0x6e616d and @rlgns98kr opinions.

I will close this PR after every member verifies the result.

Let me think about how to merge to OR-1810. Thank you very much, Theo!

And I agree your opinion. We can close this PR instead of editing base branch!