Draft: Prevent locking funds when using sendMessage with the target is an EOA and value > 0

tokamak-network / tokamak-thanos

MIT License

7 stars 3 forks source link

Closed 0x6e616d closed 1 month ago

0x6e616d commented 1 month ago

In the L1XDM contract, we prevent sending ETH to this contract when using sendMessage function
In the L2XDM contract, we prevent sending the native token and the _target is an EOA when using sendMessage function, because in the relayMessage, the _target must transfer the native token when that is called.

0x6e616d commented 1 month ago

Please don't make changes in the contracts. We are all preparing the external audit (resolving test code in contracts and NAT spec...)

These changes are from the internal audit. Related to this problem we discussed before

0x6e616d commented 1 month ago

I changed it to the Draft PR. We will decide when the external audit report is finished.

github-actions[bot] commented 1 month ago

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.