tokamak-network / tokyo

tokyo monorepo
Apache License 2.0
4 stars 5 forks source link

In case crowdsale owner key has lost during ICO period. #17

Closed ggs134 closed 6 years ago

ggs134 commented 6 years ago
  1. Plz check owner authority.
  2. What's going to happen if owner key have stolen or lost? Is it serious or not?
  3. What is alternative or solution to that matters? @4000D @thomashin
ggs134 commented 6 years ago

image 1

4000D commented 6 years ago
  1. I think it's not a question. we have to check it.
  2. cannot call fianlize() or claimTokens(). If owner's private key is lost, all Ether is locked in vault forever because sale cannot be finalized. Also tokens is going to be obsolete.

Actually, zeppelin-solidity adds onlyOwner modifier to finalize() function. https://github.com/OpenZeppelin/openzeppelin-solidity/blob/master/contracts/crowdsale/distribution/FinalizableCrowdsale.sol#L24

  1. Multi-sig wallet is the exact solution in case of losing private key.
4000D commented 6 years ago

Closing key management is out of scope