search

tokamak-network / tokyo

tokyo monorepo
Apache License 2.0
4 stars 5 forks source link

KYC testing fails #6

Closed shingonu closed 6 years ago

shingonu commented 6 years ago

Something that needs to be changed in order for the KYC contract test to be successful.

  1. .deployed() -> new() https://github.com/Onther-Tech/tokyo/blob/26238729d0c662828b537ebce82f9c40c6ab2819/packages/tokyo-reusable-crowdsale/test/KYC.js#L28
  2. export default 'revert' -> export default 'invalid opcode' https://github.com/Onther-Tech/tokyo/blob/26238729d0c662828b537ebce82f9c40c6ab2819/packages/tokyo-reusable-crowdsale/test/helpers/EVMThrow.js#L1
4000D commented 6 years ago

  1. yes. tokyo-reusable-crowdsale must have only building contracts, not the tokyo-generated contracts.

  2. "revert" and "invalid opcode" should be distinguished. zeppelin's revert, throw