Additional DAO changes - Githubissues

tokamak-network / ton-staking-v2

11 stars 3 forks source link

Additional DAO changes #34

Closed zzooppii closed 1 month ago

zzooppii commented 3 months ago

A vulnerability was found in DAO AgendaManagerContract, so it was changed to disable the vulnerability and additionally, there was a policy change for the registerLayer2Candidate function.

Logic changes

[x] don't use the setExecutedCount
[x] add registerLayer2CandidateByOwner
[x] check what change on updated StakeV2.5
[x] add the dao-upgraded.md
[x] fix the Dao-upgraded.md (img upload and fix)

Test

[x] If the atomicExecute variable is set to False when creating an agenda, the agenda creation will be rejected.
[x] registerLayer2CandidateByOwner Test
[x] Test about change on updated StakeV2.5

zzooppii commented 3 months ago

If the atomicExecute variable is set to False when creating an agenda, the agenda creation will be rejected.

Test : npx hardhat test test/agenda/17.atomicExecuteAgendaTest-mainnet.js

zzooppii commented 3 months ago

registerLayer2CandidateByOwner Test

Test : npx hardhat test test/agenda/18.Layer2CandidateTest-mainnet.js

zzooppii commented 3 months ago

check what change on updated StakeV2.5

DAOCommitteeOwner change

function name change setLayer2CandidateFactory -> setCandidateAddOnFactory
storage name change layer2CandidateFactory -> candidateAddOnFactory
function change setTargetSetL2Registry -> setTargetSetL1BridgeRegistry

DAOCommittee_V1 change

function change createLayer2Candidate -> createCandidateAddOn
interface name change ILayer2CandidateFactory -> ICandidateAddOnFactory

zzooppii commented 2 months ago

How to Test

change the hardhat.config.ts
- change forking using the url sepolia
enter cli
- npx hardhat test test/agenda/19.ChangeName-test-sepolia.js