tokamak-network / ton-staking-v2

11 stars 3 forks source link

[internal test - Contract Bugs]: #58

Closed cenwadike closed 1 month ago

cenwadike commented 1 month ago

Describe the bug

Not bugs per se. Suggestions for improving code quality.

Impact

Suggestions aim to improve the coding standard and improve readability and consistent coding standard

Exploit Scenario

NA

Recommendation

Recommendations are found in the description

Zena-park commented 1 month ago
/contracts/layer2/L1BridgeRegistryV1_1.sol:
line 159 - line 179 Remove unused commented code.
_availableForRegistration: remove unused variable _name
line 411 - line 413: Remove unused commented conditional.

It has already been fixed. https://github.com/tokamak-network/ton-staking-v2/commit/37bac22659d03ac9e50455da3412ccf3ab5a6810

Zena-park commented 1 month ago

@zzooppii Please check related to DAOCommittee_V1.sol

Zena-park commented 1 month ago

@cenwadike Everything mentioned in the issue has been reflected.