tokee / lucene-solr

High cardinality faceting (SOLR-5894)
http://tokee.github.io/lucene-solr/
7 stars 1 forks source link

Enable non-DV sparse faceting in 4.10 #39

Closed tokee closed 9 years ago

tokee commented 9 years ago

Changes to Solr from 4.8 to 4.10 broke the sparse faceting code for fields without DocValues in the 4.10 release. As a consequence, enabling sparse faceting on such a field always falls back to vanilla Solr faceting.

The bug is triggered by several unit tests, where the symptom is incorrect counts. It seems tied together with the use of packed and nplanez counters, but more investigation is needed.

tokee commented 9 years ago

Most of the failing unit tests turned out to be problems with the tests themselves (i.e. they also failed with vanilla Solr faceting). Only real problem was prefix-faceting (issue #47), so non-DV sparse faceting support is hereby re-enabled.