tokee / lucene-solr

High cardinality faceting (SOLR-5894)
http://tokee.github.io/lucene-solr/
7 stars 1 forks source link

The counter pool controller does not play well with multi-core #6

Closed tokee closed 9 years ago

tokee commented 9 years ago

The SparseCounterPoolController is a singleton, which works well for a single-core Solr installation, but not so well for multi-core. When multiple cores share the same pool controller, requests for the same field in different cores will lead to a constant invalidation of the allocated pools. The result of this is that the pool caches will be nearly useless.

There should be a separate SparseCounterPoolController for each core.

tokee commented 9 years ago

The SolrIndexSearcher holds several cache structures, so adding a facetCounterCache there seems like the right move.