tokenbound / iframe

Render your NFT with its TBA.
https://docs.tokenbound.org/iframe
30 stars 55 forks source link

Parameter to specify TBA V3 in iframe URL #26

Closed devinmancuso closed 11 months ago

devinmancuso commented 11 months ago

Hi Team,

We have migrated our community V3 TBA but the opensea iframe implementation still pulls data from V2.

Could it be possible to implement a param in the url like &version=TBVersion.V3 to pull data from V3? Or are there plans to make the default version the iFrame pulls from V3?

✌️

huynhr commented 11 months ago

Hi @devinmancuso ! Thanks for posting this. We will be updating the iframe to point to V3 address. Probably have a tab system so you can still view your v2 assets while folks are migrating. I'll look into this tomorrow morning!

devinmancuso commented 11 months ago

Thanks @huynhr ! Strong vote for some way to control what comes back from URL, either both v2 and v3, or just v2 or v3, etc.

huynhr commented 11 months ago

@devinmancuso for now we can support both as people transition to V3. If there any assets in V3 it will default to V3. If there are no assets it will default to V2. There's a dropdown so you can switch between.

https://github.com/tokenbound/iframe/pull/27