tokenbound / iframe

Render your NFT with its TBA.

https://docs.tokenbound.org/iframe

30 stars 55 forks source link

ifram support ALL chains #7

Closed SweetmanTech closed 1 year ago

SweetmanTech commented 1 year ago

iframe supports ALL chains 🌈

new routing: /{chainId}/{contractAddress}/{tokenId}. ✨
Polygon
Optimism
Arbitrum
Mumbai
Optimism Goerli
Arbitrum Rinkeby
etc.

Ethereum Examples

Ethereum: https://alpha.onchainplaylist.xyz/1/0x26727ed4f5ba61d3772d1575bca011ae3aef5d36/1

Polygon Examples

Polygon: https://alpha.onchainplaylist.xyz/137/0x4e7fd608c2abfa678ee7916fc19ef1b4e718eed5/3

vercel[bot] commented 1 year ago

@SweetmanTech is attempting to deploy a commit to the Future Primitive Team on Vercel.

A member of the Team first needs to authorize it.

jaydenwindle commented 1 year ago

@SweetmanTech this looks great! In order to make this a non-breaking change, could we keep the existing mainnet-only route and add the chainId specific route alongside it? Alternatively we could add a redirect for it. This way NFTs already relying on the deployed iframe won't break when this PR is merged in

huynhr commented 1 year ago

@SweetmanTech this looks amazing, thanks for taking this one on. Everything looks good, just the same sentiments as @jaydenwindle. There are some existing projects that currently use the /contract/tokenId, so if we change to chainId/contract/tokenId then that will affect them. If we can keep the old path as well, then we can slowly deprecate and move people to the new page.

SweetmanTech commented 1 year ago

closing this in favor of the latest changes:

https://github.com/tokenbound/iframe/pull/11