search

tokencard / contracts

The Consumer Contract Wallet
GNU General Public License v3.0
94 stars 40 forks source link

Update ENS files with latest versions #545

Closed i-stam closed 4 years ago

i-stam commented 4 years ago

This tests the latest versions of ENS related files that got updated due to a bug found.

mischat commented 4 years ago

@nostdm it would be nice to have a look at the echnida tests here, or if you could explain then so we learn. It is good that they detected a change as our tests didn't detech any change to the ENS APIs we current utilise ...

mischat commented 4 years ago

@i-stam ... this looks good to me, but would like the echnida tests to pass.

nostdm commented 4 years ago

Yep I fixed the tests, it was just a tooling error

mischat commented 4 years ago

Looking at the warnings coming out of the compiler, they don't even make sense. I have looked at around 5 of them in the ENSRegistry and the PublicResolver, all of them were wrong. There was no shadowing .... this sucks, how hard would be to make a pre on the 0.5.X compiler!

mischat commented 4 years ago

@nostdm do you want to double check this ?