search

tokencard / contracts

The Consumer Contract Wallet
GNU General Public License v3.0
94 stars 40 forks source link

Transfer() may prevent wallet to interact with non updated fallbacks after the Istantbul fork #571

Open i-stam opened 4 years ago

i-stam commented 4 years ago

Regular call() should be used instead, Check also https://diligence.consensys.net/blog/2019/09/stop-using-soliditys-transfer-now/ .

There should be carefully examined it there are bugs introduced by re-entrancy. It should be possibly combined with restricting owner to EOAs (check #570)

i-stam commented 4 years ago

This is fixed in v4. We have circumvented this issue by using executeTransaction() in the backend.

mischat commented 4 years ago

@nostdm i think you should go in and understand this stuff too ...

mischat commented 4 years ago

@mischat can you look at this too