tokencard / contracts

The Consumer Contract Wallet
GNU General Public License v3.0
94 stars 40 forks source link

openZeppelin upgradeable #586

Closed i-stam closed 4 years ago

i-stam commented 4 years ago
i-stam commented 4 years ago

I would assume this upgradable proxy could be used with the 'library' approach that we spoke about few days ago - and could also be simplified - since at the moment we are adding more contracts on top of the already complex wallet contract.

If there are test that are missing, we should add them , feel free to suggest. All the previous tests are running successfully and just the basic tests for the upgradeable contracts are added. But this was supposed to be fast so we can send it to the auditor, we can add more tests in the meanwhile.

P.S. Can we make the externals/upgradeability directory called externals/upgradable or something cleaner/simpler? I think there is no problem there, we can change the name to something else. This is actually the name that openZeppeling uses so I kept it the same as we do for all the external contracts

mischat commented 4 years ago

@i-stam the other thing which I would like to get in in this PR is a link to the commit which we took the the open-zepplin upgradebale. Would be good to have the git commit captured

nostdm commented 4 years ago

I reviewed the latest changes, I think it's good that we remove the unnecessary code from the proxy.