jakub-zarembinski
commented
5 years ago Thank you for your contribution. This problem has been fixed in the v3.2.0 release, so we're closing this PR without merging.
Closed ysoftware closed 5 years ago
jakub-zarembinski
commented
5 years ago Thank you for your contribution. This problem has been fixed in the v3.2.0 release, so we're closing this PR without merging.
What is the current behavior? (You can also link to an open issue here) It takes around 15 seconds for the tests to begin.
What is the new behavior (if this is a feature change)? It takes less than 5 seconds for the tests to begin.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No
Other information: (using nodeos v1.7.3) After some update eosfactory became insufferably slow to launch. After doing some research on why that might be, I've found that node probing was taking way too long. I've played around with those 2 numbers and picked them by the best results for my case. Now the test begins on block 8 (which is ~4.5 seconds) instead of block 30.
I have to say that I'm not exactly sure why these numbers were chosen initially and how this will affect eosfactory running on other devices. I only have my macbook to test it and exact change should be tested before publishing. I just want to bring this problem to light: waiting 15 seconds to start the test is unacceptable.