search

tokenika / secure-bp-voting

Secure EOS Block Producer Voting
https://tokenika.github.io/secure-bp-voting/
MIT License
18 stars 15 forks source link

Eos not defined, missing eos.js #16

Closed c052463 closed 6 years ago

c052463 commented 6 years ago

Disclaimer: I am not a dev.

I tried generating a transaction offline, failed. In browser console. Received a warning:

Received an error:

How I got it working:

  1. I downloaded eos.js from official EOS github folder, pasted it in same folder as 2_generate_transaction.html
  2. Replaced <script src="https://github.com/EOSIO/eosjs/releases/download/v14.1.1/eos.js"></script> with <script src="eos.js"></script> in 2_generate_transaction.html

Was it suppose to work without doing what I did?

noisy commented 6 years ago

Please follow the instructions provided on https://tokenika.github.io/secure-bp-voting/2_generate_transaction.html :)

First of all, save this website to your local machine (right click, Save as…)

Goal of Tokenika is to not add build version of eos.js library directly to this repository, because it would be very difficult for everyone to audit this file, and make sure, that we didn't altered it.

That's why we are linking to official repository and to file build by Block One, not by us.

If a user follows the instructions provided by us, then a browser downloads linked file automatically, when a user click "Save as...". If someone prefer to clone a repository, then he needs to download eos.js file on his own. But we recommend first method because of simplicity.

c052463 commented 6 years ago

Thank you for highlighting that. My apologizes for assuming downloading the whole zip would work. I just downloaded the zip and that is why the error occurred.

You are doing great job!!