search

tokenly / swapbot

Exchange tokens with an automated machine
3 stars 4 forks source link

Fiat priced swaps refund if bitcoin rate falls too low before confirmation #244

Closed deweller closed 8 years ago

deweller commented 8 years ago

Swapbot locks in the rate of exchange when the zero-conf transaction is seen.

But the Swapbot doesn’t use the locked in rate when checking whether to refund or process the swap. So if the bitcoin rate rises too high during the 2 incoming confirmations, then Swapbot may incorrectly choose to refund the swap instead of processing it.

deweller commented 8 years ago

For clarification, it turns out the issue was when the bitcoin rate drops after the initial confirmation was seen.